[Fwd: Re: {Disarmed} Two new Bugzilla issues which are VHPI related]

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

attached mail follows:

I agree with the changes proposed by Peter.
Francoise
       '


________________________________

	From: owner-vhpi-pilot@eda.org [mailto:owner-vhpi-pilot@eda.org]
On Behalf Of Chuck Swart - MTI
	Sent: Friday, June 27, 2008 8:36 PM
	To: vhpi-pilot@eda.org
	Subject: {Disarmed} Two new Bugzilla issues which are VHPI
related
	
	
	Bugzilla  235 Error in name of property of foreignf class
	Bugzilla  236 Wrong case for specName property of blockConfig
class
	
	These are relatively minor typos--please review if and when you
have the opportunity.
	
	Text follows
	
	235:
	
	In 19.5, the foreignf class has a property named ForeognT of
type ForeignT.
	There are two problems. First, there is the typo. Presumably
ForeognT should be
	ForeignT. Second, with that correction, the property name is
then the same as
	the type name. Apart from being confusing, it is inconsistent
with naming of
	properties in other classes. The convention for a property that
is of an enum
	type is to name the property Blah and the enum BlahT. Examples
are Staticness of
	type StaticnessT in class expr, State of type StateT in class
callback, SigKind
	of type SigKindT in class sigDecl, and others.
	
	The property of class foreignf should be renamed to Foreign.

	------- Additional Comment #1
<https://bugzilla.mentor.com/show_bug.cgi?id=235#c1>  From Peter
Ashenden <mailto:peter@ashenden.com.au>  2008-06-21 23:25 [reply
<https://bugzilla.mentor.com/show_bug.cgi?id=235#add_comment> ] ------- 
	As it turns out, there is an enum value vhpiForeignKindP that
doesn't correspond
	to any property, and the enum value fo the Foreign property is
missing. The name
	ForeignKind for the property makes better sense. The
documentation for it is:
	
	  The value of type ForeignT corresponding to the kind of
foreign model
	  or application.
	
	I'd suggest changing the property name to ForeignKind, the enum
type to
	vhpiForeignKindT, and keeping the vhpiForeignKindP enum value.

	------- Additional Comment #2
<https://bugzilla.mentor.com/show_bug.cgi?id=235#c2>  From Peter
Ashenden <mailto:peter@ashenden.com.au>  2008-06-26 20:24 [reply
<https://bugzilla.mentor.com/show_bug.cgi?id=235#add_comment> ] ------- 
	At ISAC telecon of 26-Jun, suggested change accepted.

	------- Additional Comment #3
<https://bugzilla.mentor.com/show_bug.cgi?id=235#c3>  From Peter
Ashenden <mailto:peter@ashenden.com.au>  2008-06-26 21:46 [reply
<https://bugzilla.mentor.com/show_bug.cgi?id=235#add_comment> ] ------- 
	Changes implemented, to appear in D4.3
	
	236:
	In 19.5, page 315 of D4.2 clean, Figure 3, the blockConfig class
is shown as
	having the specName property. The property name should start
with a capital
	letter (SpecName) for consistency with other property names.

	------- Additional Comment #1
<https://bugzilla.mentor.com/show_bug.cgi?id=236#c1>  From Peter
Ashenden <mailto:peter@ashenden.com.au>  2008-06-26 20:25 [reply
<https://bugzilla.mentor.com/show_bug.cgi?id=236#add_comment> ] ------- 
	At ISAC telecon of 26-Jun, suggested change accepted

	------- Additional Comment #2
<https://bugzilla.mentor.com/show_bug.cgi?id=236#c2>  From Peter
Ashenden <mailto:peter@ashenden.com.au>  2008-06-26 22:04 [reply
<https://bugzilla.mentor.com/show_bug.cgi?id=236#add_comment> ] ------- 
	Change implemented, to appear in D4.3
	


	-- 
	This message has been scanned for viruses and 
	dangerous content by MailScanner <http://www.mailscanner.info/>
, and is 
	believed to be clean.