Re: sc_event_or_list const &

On 12/01/11 15:18, john.aynsley@doulos.com wrote:
> I agree with Alan and Bishnupriya.
>
> Philipp - any objections?

For consistency, I agree as well.
It was not intentional, I'm just used to this notation personally.

I already sent an updated patch to Andy with the "const T&" notation.

P.

> From:
> Bishnupriya Bhattacharya <bpriya@cadence.com>
> To:
> "john.aynsley@doulos.com" <john.aynsley@doulos.com>,
> "systemc-p1666-technical@eda.org" <systemc-p1666-technical@eda.org>
> Date:
> 11/01/2011 18:31
> Subject:
> RE: sc_event_or_list const &
>
>
>
> I think we should change to the old fashioned style
>
> void next_trigger(const sc_time&, const sc_event_or_list&);
>
> -Bishnupriya
>
> From: owner-systemc-p1666-technical@eda.org [
> mailto:owner-systemc-p1666-technical@eda.org] On Behalf Of
> john.aynsley@doulos.com
> Sent: Tuesday, January 11, 2011 7:13 PM
> To: systemc-p1666-technical@eda.org
> Subject: sc_event_or_list const &
>
> All,
>
> Alan writes:
> p60
> There are a whole lot of functions declared in a different style e.g.
>
> void next_trigger(const sc_time&, sc_event_or_list const &);
>
> I think this is inconsistent. Either the whole standard should be changed
> to that style e.g.
>
> void next_trigger(sc_time const &, sc_event_or_list const &);
>
> or (easier!)
>
> these functions should be written in the old-fashioned
> void next_trigger(const sc_time&, const sc_event_or_list &);
>
> Otherwise it will just confuse people.
> Same on p72ff section 6.2.17
> Same in section 6.2.18
> Same in section 6.9.2, 6.9.4
> Same in section 6.15.2
>
> [JA] I agree. I was lazy and simply copied the function declarations from
> Philipp's prototype, but as things stand the LRM is no longer
> self-consistent.
>
>
> Opinions?
>
>
> John A
>

-- 
Philipp A. Hartmann
Hardware/Software Design Methodology Group
OFFIS Institute for Information Technology
R&D Division Transportation · FuE-Bereich Verkehr
Escherweg 2 · 26121 Oldenburg · Germany · http://offis.de/en/
Phone/Fax: +49-441-9722-420/282 · PGP: 0x9161A5C0 · Skype: phi.har
-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.