Subject: Re: [sv-cc] Updated LRM
From: Stickley, John (john_stickley@mentorg.com)
Date: Wed Mar 19 2003 - 09:56:39 PST
Andrzej,
Andrzej Litwiniuk wrote:
>
> /* canonical <-- actual */
> svBitVec32 svGetBits(const svBitPackedArrRef s, int i, int w);
> svBitVec32 svGet32Bits(const svBitPackedArrRef s, int i); // 32-bits
> long long svGet64Bits(const svBitPackedArrRef s, int i); // 64-bits
It looks good but I would prefer the following for the bit
select functions:
typedef long long svBitVec64;
svBitVec32 svGet32Bits(
const svBitPackedArrRef s, int i, int w); // Up to 32-bits
svBitVec64 svGet64Bits(
const swBitPacketArrRef s, int i, int w ); // Up to 64-bits
I think it is important to include the 'w' parameter in both so
that proper masking can be applied before the result is returned.
Plus this is more consistent with what is already in there for
svGetPartSelectBit() (and what you have listed for svGetBits()).
-- johnS
__
______ | \
______________________/ \__ / \
\ H Dome ___/ |
John Stickley E | a __ ___/ / \____
Principal Engineer l | l | \ /
Verification Solutions Group | f | \/ ____
Mentor Graphics Corp. - MED C \ -- / /
17 E. Cedar Place a \ __/ / /
Ramsey, NJ 07446 p | / ___/
| / /
mailto:John_Stickley@mentor.com \ /
Phone: (201)818-2585 \ /
---------
This archive was generated by hypermail 2b28 : Wed Mar 19 2003 - 09:57:42 PST