Subject: [sv-cc] Detailed comments on latest rev of Bassam's proposal
From: Warmke, Doug (doug_warmke@mentorg.com)
Date: Fri Nov 21 2003 - 13:54:41 PST
Bassam,
Here are some comments & questions on the proposal from our
internal R&D staff. We feel you are moving in the right
direction. Please keep up the progress!
Regards,
Doug
1) The references to "vpi_get_value(vpiType,<object_handle>)"
on pages 2 and 5 are incorrect. The prototype of vpi_get_value()
is vpi_get_value( <object_handle>, <value_pointer> ).
2) I don't understand this sentence in section 29.2.2.2.2:
"The function can be alteratively obtained indirectly through
a combination of vpi_control() call to go to the min, max, or
specific time, or without calling vpi_control() use the place the
handle is already pointing at (if valid), and a vpi_get_time()
call."
Is this trying to say that vpi_control() moves to the specified
time whereas vpi_get_time() simply returns the time being pointed at?
This needs to be reworded.
3) A comment should be inserted somewhere that specifically states
that vpi_scan() does NOT automatically free a collection handle
that it is scanning when it returns NULL.
4) In regard to time-ordered traversal using a traverse collection,
when vpi_control() is used to move to the next or previous
value change, there is no way to know which objects in the
collection are the ones that had actual value changes. You
basically have to get the value of every object in the collection
because you can't tell which one changed. Is this the intended
functionality?
5) vpi_trvs_get_time() - In regard to vpiTrvsTime used on a traverse
collection, instead of having it be "undefined and left to tool
implementation", why not define something so tools can be consistent?
How about giving this function a return value? It could return 1
on success and 0 on failure. It would succeed if the handle is a
single object or a collection where all objects in the collection
are at the same time. It would fail if the handle is a collection
where all objects in the collection are not at the same time. On
failure, the time_p parameter would not be modified.
This archive was generated by hypermail 2b28 : Fri Nov 21 2003 - 13:55:58 PST