Subject: RE: [sv-cc] Assertion errata
From: Bassam Tabbara (bassam@novas.com)
Date: Wed Dec 10 2003 - 10:27:10 PST
Thanks Francoise, I'll update momentarily ... Quick response here,
please see below.
-- Dr. Bassam Tabbara Technical Manager, R&D Novas Software, Inc.http://www.novas.com (408) 467-7893
> -----Original Message----- > From: owner-sv-cc@eda.org [mailto:owner-sv-cc@eda.org] On > Behalf Of Francoise Martinolle > Sent: Wednesday, December 10, 2003 9:55 AM > To: sv-cc@eda.org > Subject: [sv-cc] Assertion errata > > > Comments on the assertion errata. > Sorry It come so late but I found some editorial issues to be fixed. > > > We should either provide all the available types. > PLI_INT32 assertionType; /* vpiSequenceType, ... */
Done. > For the assertion errata, I think it is confusing (when I > read) to embed > the prototype of the callback function in vpi_register_assertion_cb. > > I would prefer if there would be a function prototype used > and defined.
Too much change, and will probably introduce more errors, ignoring in this rev. > The return type of vpi_get_assertion_info should be PLI_INT32 > int vpi_get_assertion_info (assert_handle, p_vpi_assertion_info);
Done.
> The following sentence : > 2) a pointer to the time of the callback > should be changed to: > 2) a pointer to the time of the assertion attempt
The intent is really to say "callback" as in /* callback time */, it should be clear what that is (much like "callback reason") ... Putting "attempt" in there would create confusion. So ignoring for now. > The following sentence: > 5) a reference to the user data supplied when the callback > was placed. should be changed to: > 5) a reference to the user data supplied when the callback > was registered.
Done. > Replace : > On disable, enable, reset and kill callbacks, the info field > is absent (a NULL pointer is given as the value > > of info). > With: > On disable, enable, reset and kill callbacks, the info field is NULL.
Done. > Replace : > On a step callback, the attemptStartTime and detail.step > elements are valid. > with: > On a step callback, the attemptStartTime and detail.step are valid.
Done. > Replace (incomplete sentence) > - For the following operator, the second argument shall be a > valid assertion handle, the third argument shall > > be an attempt start-time (as a pointer to a correctly > initialized s_vpi_time structure) and the fourth argument > > shall be a step control constant. > > Usage example: vpi_control(vpiAssertionEnableStep, > assertionHandle, attemptStartTime, > > With: > - For this operation, the second argument shall be a valid > assertion handle, the third argument shall > > be an attempt start-time (as a pointer to a correctly > initialized s_vpi_time structure) and the fourth argument > > shall be a step control constant. > > Usage example: vpi_control(vpiAssertionEnableStep, > assertionHandle, attemptStartTime, assertionEnableStep)
No, it is correct as is (consistent with the rest), there is a page break, the last argument is on the next page and it is *vpiAssertionClockSteps*.
Thanks Francoise. -Bassam.
This archive was generated by hypermail 2b28 : Wed Dec 10 2003 - 10:27:52 PST