[sv-cc] Re: vpi_user.h: PLI error information structure

Hi Shalom,

Yes, these comments would be okay.

   -Chas

Shalom.Bresticker@freescale.com wrote:
> The following appears in vpi_user.h:
>
> /************************ PLI error information structure *********************/
>
> typedef struct t_vpi_error_info
> {
> PLI_INT32 state; /* vpi[Compile,PLI,Run] */
> PLI_INT32 level; /* vpi[Notice,Warning,Error,System,Internal] */
> PLI_BYTE8 *message;
> PLI_BYTE8 *product;
> PLI_BYTE8 *code;
> PLI_BYTE8 *file;
> PLI_INT32 line;
> } s_vpi_error_info, *p_vpi_error_info;
>
> /* error types */
>
> #define vpiCompile 1
> #define vpiPLI 2
> #define vpiRun 3
>
> #define vpiNotice 1
> #define vpiWarning 2
> #define vpiError 3
> #define vpiSystem 4
> #define vpiInternal 5
>
>
> It appears to me that the comment "error types" is not precise,
> and the list of #defines starting with vpiNotice also requires an
> explanatory comment.
>
> I propose:
>
> /* state when error occurred */
>
> and
>
> /* error severity levels */
>
> Is that ok?
>
> Thanks,
> Shalom
>

-- 
Charles Dawson
Senior Engineering Manager
NC-Verilog Team
Cadence Design Systems, Inc.
270 Billerica Road
Chelmsford, MA  01824
(978) 262 - 6273
chas@cadence.com